Skip to content

[Lark] - New Destination#3479

Merged
joe-ayoub-segment merged 5 commits intosegmentio:mainfrom
uselark:main
Jan 6, 2026
Merged

[Lark] - New Destination#3479
joe-ayoub-segment merged 5 commits intosegmentio:mainfrom
uselark:main

Conversation

@jackcbrown89
Copy link
Contributor

@jackcbrown89 jackcbrown89 commented Dec 15, 2025 •
edited
Loading

Added destination for sending usage to https://uselark.ai

Testing

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

Security Review

Please ensure sensitive data is properly protected in your integration.

  • Reviewed all field definitions for sensitive data (API keys, tokens, passwords, client secrets) and confirmed they use type: 'password'

@joe-ayoub-segment joe-ayoub-segment self-assigned this Dec 17, 2025
@joe-ayoub-segment
Copy link
Contributor

joe-ayoub-segment commented Dec 17, 2025 •
edited
Loading

Thanks for the PR @jackcbrown89 - I'll schedule for review once you convert from draft.

@joe-ayoub-segment joe-ayoub-segment changed the title added lark destination [Lark] - New Destination Dec 17, 2025
@jackcbrown89 jackcbrown89 marked this pull request as ready for review December 22, 2025 18:52
@jackcbrown89 jackcbrown89 requested a review from a team as a code owner December 22, 2025 18:52
@joe-ayoub-segment
Copy link
Contributor

joe-ayoub-segment commented Dec 23, 2025 •
edited
Loading

LGTM @jackcbrown89 ,
Couple of questions before I deploy this.

  1. Does Lark have any standard event names or standard event data items / properties? if so, it might be worth adding some default mappings for these properties.
  2. Do you also want to collect user profile details (first_name, last_name, email etc)? If so, it might be worth implementing an Action to handle identify() calls.

Also could you please email me your email address as I'll need to invite you to the partner portal. my email is jayoub@twilio.com

Best regads,
Joe

@redox redox mentioned this pull request Dec 29, 2025
Closed
6 tasks
@jackcbrown89
Copy link
Contributor Author

jackcbrown89 commented Jan 2, 2026

Thanks @joe-ayoub-segment . I just sent you an email.

  1. Does Lark have any standard event names or standard event data items / properties? if so, it might be worth adding some default mappings for these properties.

No, the event data and event names are all user-defined.

  1. Do you also want to collect user profile details (first_name, last_name, email etc)? If so, it might be worth implementing an Action to handle identify() calls.

Not at the moment, as we don't have any guaranteed ways of mapping standard profile details to a Lark subject. That's also a user-defined identifier so we would risk creating duplicates.

@joe-ayoub-segment
Copy link
Contributor

joe-ayoub-segment commented Jan 5, 2026 via email

@joe-ayoub-segment joe-ayoub-segment merged commit 4d93ad9 into segmentio:main Jan 6, 2026
12 of 14 checks passed
@joe-ayoub-segment
Copy link
Contributor

joe-ayoub-segment commented Jan 6, 2026

PR deployed

@jackcbrown89 jackcbrown89 mentioned this pull request Jan 8, 2026
Draft
AnkitSegment added a commit that referenced this pull request Jan 24, 2026
@AnkitSegment
Squashed commit of the following:
a2b04a7 
commit 7e1b061
Author: Ankit Gupta <ankit.gupta@segment.com>
Date:   Wed Jan 7 13:41:16 2026 +0530

    Removed hidden key from enable batching

commit 5b5b6c8
Author: Joe Ayoub <45374896+joe-ayoub-segment@users.noreply.github.com>
Date:   Tue Jan 6 14:00:55 2026 +0000

    empty commit (#3507)

commit 8864be1
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Tue Jan 6 10:37:55 2026 +0000

    Publish (#3506)

    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

commit 131c2e7
Author: Joe Ayoub <45374896+joe-ayoub-segment@users.noreply.github.com>
Date:   Tue Jan 6 10:30:04 2026 +0000

    Register 3 new destinations (#3505)

commit 5c97538
Author: Joe Ayoub <45374896+joe-ayoub-segment@users.noreply.github.com>
Date:   Tue Jan 6 10:00:21 2026 +0000

    [Collab Travel CRM] - slug rename (#3504)

commit e3d0705
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Tue Jan 6 09:32:25 2026 +0000

    Publish (#3503)

    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

commit 0ce7ea9
Author: Joe Ayoub <45374896+joe-ayoub-segment@users.noreply.github.com>
Date:   Tue Jan 6 09:14:57 2026 +0000

    STRATCONN-6453 - [Optimizely Advanced Audience Targeting] - bugfix (#3492)

    * bug fix

    * making trait or props new field hidden in UI

commit 529d3d5
Author: Joe Ayoub <45374896+joe-ayoub-segment@users.noreply.github.com>
Date:   Tue Jan 6 09:03:12 2026 +0000

    STRATCONN-6456 - [Collab Travel CRM] - new Destination (#3502)

commit c98417d
Author: Joe Ayoub <45374896+joe-ayoub-segment@users.noreply.github.com>
Date:   Tue Jan 6 08:40:50 2026 +0000

    Fix main branch - airship linting issue (#3501)

commit 74abc90
Author: Joe Ayoub <45374896+joe-ayoub-segment@users.noreply.github.com>
Date:   Tue Jan 6 08:40:39 2026 +0000

    [Zapier] - bug fixes (#3487)

    * [Zapier] - bug fixes

    * removing accidentally added braze file

commit 4d93ad9
Author: Jack Brown <jackcbrown89@gmail.com>
Date:   Tue Jan 6 00:20:17 2026 -0800

    [Lark] - New Destination (#3479)

    * added lark destination

    * always get `subject_id` from $.userId

    * v0.0.0

    * remove package.json change

    * remove added newline

commit 6d2cd9f
Author: Joe Ayoub <45374896+joe-ayoub-segment@users.noreply.github.com>
Date:   Tue Jan 6 08:06:49 2026 +0000

    [Altertable] - new Destination (#3498)

commit 4042a9b
Author: Sayan Das <109198085+sayan-das-in@users.noreply.github.com>
Date:   Tue Jan 6 13:16:10 2026 +0530

    fix await statement (#3493)

commit e5dba9d
Author: john greene <jumpinggrendel@gmail.com>
Date:   Mon Jan 5 23:44:10 2026 -0800

    correctly cast non-date items (#3496)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joe-ayoub-segment joe-ayoub-segment joe-ayoub-segment approved these changes

@sayan-das-in sayan-das-in sayan-das-in approved these changes

Assignees

@joe-ayoub-segment joe-ayoub-segment

Labels

deploy:push deploy:registration mode:cloud partner-eng-review (cloud) Ready for Release team:external

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jackcbrown89 @joe-ayoub-segment @sayan-das-in